Skip to content

Conversation

koji
Copy link
Contributor

@koji koji commented Aug 8, 2025

Overview

fix font-size for web

design
https://www.figma.com/design/1ot18My22DALIcjdLl5LJh/Helix-Design-System?node-id=358-31898&m=dev

touchscreen 20px
web(desktop app, pd, and pl) 16px

this should be a temp patch

Screenshot 2025-08-08 at 1 41 57 PM

close RQA-4502

Test Plan and Hands on Testing

Changelog

Review requests

Risk assessment

low

@koji koji requested review from ncdiehl11 and jerader August 8, 2025 17:54
@koji koji marked this pull request as ready for review August 8, 2025 17:54
@koji koji requested a review from a team as a code owner August 8, 2025 17:54
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.73%. Comparing base (d86ae7a) to head (b6750a9).
⚠️ Report is 15 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #19172      +/-   ##
==========================================
- Coverage   24.96%   23.73%   -1.24%     
==========================================
  Files        3378     3378              
  Lines      297125   297122       -3     
  Branches    31525    31532       +7     
==========================================
- Hits        74170    70510    -3660     
- Misses     222931   226594    +3663     
+ Partials       24       18       -6     
Flag Coverage Δ
app 0.97% <ø> (-2.09%) ⬇️
protocol-designer 18.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops good catch!

@koji koji merged commit 861d401 into edge Aug 11, 2025
66 of 67 checks passed
@koji koji deleted the fix_RQA-4502 branch August 11, 2025 14:56
neo-jesse pushed a commit that referenced this pull request Aug 19, 2025
* fix(components): fix font-size for web
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants